Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
21b5094 to
62f2dee
Compare
62f2dee to
306391e
Compare
Change the docker compose setup to use nginx as the primary web interface. nginx terminates the TLS connection and provides the static files of GSA.
306391e to
64bfb39
Compare
ozgen
reviewed
Feb 25, 2026
| | gsad | gsad | A container running the {term}`gsad` service for providing the web API. It translates between http and {term}`GMP`. For communication with gvmd, a unix socket in a volume is used. | | ||
| | gsa | | A container that copies the static content for the web application {term}`GSA` to the `gsa_data_vol` volume on startup. | | ||
| | gvm-config | | A container providing the nginx config and self-signed certificates for https | | ||
| | nginx | nginx | A nginx web server providing {term}`GSA` | |
Member
There was a problem hiding this comment.
We could also add e.g.: It forwards API requests to the gsad service.
Suggested change
| | nginx | nginx | A nginx web server providing {term}`GSA` | | |
| | nginx | nginx | A nginx web server providing {term}`GSA`. It forwards API requests to the gsad service. | |
ozgen
reviewed
Feb 25, 2026
| | gsa | gsad | A container running the {term}`gsad` web server for providing the web application {term}`GSA`. The web interface is available at localhost on port 9392. For communication with gvmd, a unix socket in a volume is used. | | ||
| | gsad | gsad | A container running the {term}`gsad` service for providing the web API. It translates between http and {term}`GMP`. For communication with gvmd, a unix socket in a volume is used. | | ||
| | gsa | | A container that copies the static content for the web application {term}`GSA` to the `gsa_data_vol` volume on startup. | | ||
| | gvm-config | | A container providing the nginx config and self-signed certificates for https | |
Member
There was a problem hiding this comment.
Suggested change
| | gvm-config | | A container providing the nginx config and self-signed certificates for https | | |
| | gvm-config | | A container providing the nginx config and self-signed certificates for https communication. | |
ozgen
reviewed
Feb 25, 2026
| ## Latest | ||
|
|
||
| * Only provide a docker-compose.yml file and remove the versioned file. The | ||
| compose file is a rolling release. |
Member
There was a problem hiding this comment.
First bullet point is a bit unclear.
e.g.:
- Provide a single docker-compose.yml file and remove the versioned compose file. The compose setup now follows a rolling release model.
ozgen
reviewed
Feb 25, 2026
|
|
||
| * Only provide a docker-compose.yml file and remove the versioned file. The | ||
| compose file is a rolling release. | ||
| * Change compose setup to use nginx for serving GSA and run gsad in api only |
Member
There was a problem hiding this comment.
same for the second one e.g.:
- Update the compose architecture:
- Use nginx to serve the GSA frontend.
- Run gsad in API-only mode.
- Introduce a new gvm-config container that configures nginx and generates a self-signed TLS certificate.
- Port 9392 now redirects to 443.
Member
|
I have tested new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Nginx based setup for providing GSA
Why
Change the docker compose setup to use nginx as the primary web interface. nginx terminates the TLS connection and provides the static files of GSA.
References
https://jira.greenbone.net/browse/GEA-1565
Checklist